Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope Vite dev exports in dev/vite entry #11904

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

markdalgleish
Copy link
Member

This PR adds a @react-router/dev/vite entry so that all Vite-related exports don't need to be namespaced or aliased. We avoided this in the past because we didn't use package exports to limit reaching into package internals, but since we now define package exports, we're free to make this change.

-import {
-  vitePlugin as reactRouter,
-  cloudflareDevProxyVitePlugin,
-} from "@react-router/dev";

+import {
+  reactRouter,
+  cloudflareDevProxy,
+} from "@react-router/dev/vite";

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 39edb2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@react-router/dev Major
react-router Major
react-router-dom Major
@react-router/architect Major
@react-router/cloudflare Major
@react-router/express Major
@react-router/node Major
@react-router/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 8540316 into dev Aug 19, 2024
8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/add-dev-vite-entry branch August 19, 2024 06:35
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant