Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for v7 flags in v6 #11750

Merged
merged 16 commits into from
Oct 18, 2024
Merged

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jun 28, 2024

  • Add deprecation warnings for v7 future flags in v6
  • Add @deprecated annotations to json/defer

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 3bcaf77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Minor
react-router Minor
@remix-run/router Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 changed the base branch from dev to v6 July 16, 2024 18:03
@brophdawg11 brophdawg11 marked this pull request as draft August 15, 2024 20:47
@brophdawg11 brophdawg11 marked this pull request as ready for review October 11, 2024 19:59
@brophdawg11 brophdawg11 merged commit caa0895 into v6 Oct 18, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/v6-deprecations branch October 18, 2024 14:16
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🤖 Hello there,

We just published version 6.28.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@li-jia-nan
Copy link

How do I turn off these warnings ?

@pterblgh
Copy link

Hey team, our CI is full of these log lines. What's the recommended approach to disable them? Most packages usually give package consumers and environment variable to turn off logging.
image

These lines are logged 498 times for our repo, probably unnecessarily:
image

What is your recommendation?

@jkakar
Copy link

jkakar commented Nov 13, 2024

How should code like return json({ error: "some error" }, { status: 400 }); be handled in the new world?

@adriandmitroca
Copy link

Shouldn't these deprecation warnings happen only in non-production environment?

Copy link
Contributor

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11
Copy link
Contributor Author

We're going to allow you to disable these warnings by setting the flags to false in a 6.28.1 release soon: #12441

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add deprecation warnings to RR v6 and Remix v2
5 participants