Dedup relative path logic in resolveTo #11097
Conversation
🦋 Changeset detectedLatest commit: 515eaa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (toPathname.startsWith("..")) { | ||
| let toSegments = toPathname.split("/"); | ||
|
|
||
| // With relative="path", each leading .. segment means "go up one URL segment" | ||
| while (toSegments[0] === "..") { | ||
| toSegments.shift(); | ||
| fromSegments.pop(); | ||
| } | ||
|
|
||
| to.pathname = toSegments.join("/"); | ||
| } |
There was a problem hiding this comment.
This logic already happens in resolvePath below - we just need to pick the proper from path
| // "go up one route" instead of "go up one URL segment". This is a key | ||
| // difference from how <a href> works and a major reason we call this a | ||
| // "to" value instead of a "href". | ||
| if (!isPathRelative && toPathname.startsWith("..")) { |
There was a problem hiding this comment.
We just need to skip processing any .. segments in to when generating our from pathname when relative="path"
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
No description provided.