Better handling of deferred promises that resolve/reject with undefined #10690
Conversation
🦋 Changeset detectedLatest commit: ba5804c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/router/utils.ts
Outdated
| // Option 1 | ||
| if (data === undefined) { | ||
| Object.defineProperty(promise, "_error", { | ||
| get: () => | ||
| new Error( | ||
| `Deferred data for key ${key} resolved to \`undefined\`, you must resolve with a value or \`null\`.` | ||
| ), | ||
| }); | ||
| this.emit(false, key); | ||
| return Promise.reject(error); | ||
| } |
There was a problem hiding this comment.
This approach better aligns with our handling of function loader() { return undefined; }
|
LGTM - just minor refactor questions - take 'em or leave 'em 😄 |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Alternate fix for remix-run/remix#6793