Fix Windows build #379
Merged
Fix Windows build #379
+56
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged but let me know if something's off. |
Merged
|
@gaearon There's a NPM package called better-npm-run which allows you to set env variables in a cross-platform way. I created a pull request for react-redux-universal-hot-example which uses it: erikras/react-redux-universal-hot-example#71 |
|
Oh, neat. I'll stay with separate configs for now, but if I feel I need something more, I'll make sure to use it! |
|
@gaearon All good on Windows with the separate configs! |
|
👍 |
jamesxv7
added a commit
to jamesxv7/redux
that referenced
this pull request
Apr 10, 2017
A missing `>` was located at line reduxjs#379
timdorr
pushed a commit
that referenced
this pull request
Apr 10, 2017
A missing `>` was located at line #379
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
A missing `>` was located at line reduxjs#379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should (hopefully) finally fix the Windows build by removing env variables (since they're set on Windows in a different way, and I can't figure out how to make it work cross-platform).
@mikekidder, I'd appreciate you testing this!