[v24.3.x] storage: add log lines about removed data #24736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some accounting to the copy_data_segment_reducer to keep track of records and batches that are removed. The goal here is ultimately to provide more visibility into removed records, though this accounting isn't yet plugged into anything. A later change will expose numbers (likely with logging). (cherry picked from commit 33c3aa4)
andrwng
added
kind/backport
CONFLICT: - conflict because this branch doesn't have pb.add_segment_marked_tombstone_free() Removing records from the storage layer is currently very silent, making it difficult to debug. This commit exposes the new copy_data_segment_reducer stats in as a log message, at info level when data is removed, and debug level when not (presumably we mostly care about these stats when data is actually being removed). (cherry picked from commit 8c84ffd)
andrwng
force-pushed
the
manual-backport-24659-v24.3.x-337
branch
from
ed7b6f7 to
f125faf
Compare
CI test resultstest results on build#60462
|
WillemKauf
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24659
CONFLICT: