Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] [CORE-8141] Add host information to metrics report #24044

Conversation

vbotbuildovich
Copy link
Collaborator

@vbotbuildovich vbotbuildovich commented Nov 7, 2024

Backport of PR #24023

Fixes: Fixes: CORE-8174

Added hostname, domainname, and a list of FQDNs to the call-home report

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit f1b77e8)
@vbotbuildovich vbotbuildovich added this to the v24.1.x-next milestone Nov 7, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Nov 7, 2024
@michael-redpanda michael-redpanda force-pushed the backport-pr-24023-v24.1.x-62 branch from 4a11ea5 to bfd2623 Compare November 7, 2024 03:46
@michael-redpanda
Copy link
Contributor

Force push bfd2623:

  • Header moved in later versions of RP

@michael-redpanda michael-redpanda requested review from a team, oleiman and michael-redpanda and removed request for a team November 7, 2024 03:46
@michael-redpanda michael-redpanda self-assigned this Nov 7, 2024
Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 99df629)
@michael-redpanda michael-redpanda force-pushed the backport-pr-24023-v24.1.x-62 branch from bfd2623 to e84f497 Compare November 7, 2024 15:09
@michael-redpanda
Copy link
Contributor

Force push e84f497:

  • Actually commited the change

@vbotbuildovich
Copy link
Collaborator Author

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/57784#01930769-f77f-4aee-8ba6-4675650c6216:

"rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.ms"

@vbotbuildovich
Copy link
Collaborator Author

Retry command for Build#57784

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/archive_retention_test.py::CloudArchiveRetentionTest.test_delete@{"cloud_storage_type":1,"retention_type":"retention.ms"}

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -18,6 +18,7 @@
#include "features/fwd.h"
#include "http/client.h"
#include "model/metadata.h"
#include "net/unresolved_address.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is it yeah?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah sorry I should have called it out

@michael-redpanda michael-redpanda merged commit 69ea20f into redpanda-data:v24.1.x Nov 7, 2024
14 of 17 checks passed
@BenPope BenPope modified the milestones: v24.1.x-next, v24.1.18 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants