Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk/transform/buildpack: upgrade tinygo #23969

Merged
merged 1 commit into from
Nov 1, 2024
Merged

rpk/transform/buildpack: upgrade tinygo #23969

merged 1 commit into from
Nov 1, 2024

Conversation

rockwotj
Copy link
Contributor

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • Upgrade data transforms tinygo compiler to version 0.34.0

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 31, 2024 •
edited
Loading

the below tests from https://buildkite.com/redpanda/redpanda/builds/57400#0192e096-dbf4-4bc2-8767-a9e8c44a6880 have failed and will be retried

catalog_schema_manager_rpunit

the below tests from https://buildkite.com/redpanda/redpanda/builds/57435#0192e3bc-1141-48f3-a538-a85117786581 have failed and will be retried

catalog_schema_manager_rpunit

@rockwotj rockwotj enabled auto-merge October 31, 2024 17:59
@rockwotj rockwotj requested a review from oleiman October 31, 2024 18:00
oleiman
oleiman approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/go/rpk/pkg/cli/transform/buildpack/buildpack.go
Comment on lines +104 to +106
template.Must(t, t.Execute(b, map[string]string{
"Name": bp.Name,
"BaseURL": bp.baseURL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: the "Name" field is quietly ignored if it doesn't appear in the base template then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly

@rockwotj rockwotj merged commit ef3ba1a into redpanda-data:dev Nov 1, 2024
22 checks passed
@oleiman
Copy link
Member

oleiman commented Nov 6, 2024

/backport v24.2.x

@oleiman
Copy link
Member

oleiman commented Nov 6, 2024

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream /~https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23969-v24.2.x-358 remotes/upstream/v24.2.x
git cherry-pick -x 2bbb3918b3

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Nov 6, 2024
Closed
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream /~https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23969-v24.1.x-349 remotes/upstream/v24.1.x
git cherry-pick -x 2bbb3918b3

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@twmb twmb Awaiting requested review from twmb

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/build area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockwotj @vbotbuildovich @oleiman