[v24.1.x] admin: add cloud_storage_cache_size check to config_multi_property_validation() (manual backport)
#23362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To encapsulate the logic for validating a `cluster` level configuration
for the properties `cloud_storage_cache_size` and `cloud_storage_cache_size_percent`.
The following configurations are determined to be invalid:
1. `cloud_storage_cache_size` and `cloud_storage_cache_size_percent`
cannot both be 0
2. `cloud_storage_cache_size` cannot be 0 while
`cloud_storage_cache_size_percent` is nil (`std::nullopt`)
(cherry picked from commit ff73a96)
To prevent the invalid configuration of `cloud_storage_cache_size` and `cloud_storage_cache_size_percent` both equal to 0, add a new check to the `admin` server validation post `patch_cluster_config_handler()` call. Validation is performed at the admin endpoint level to prevent users from configuring the cluster settings to one of these invalid states, which would result in the cloud cache calculating its max size as 0. (cherry picked from commit d4674d6)
(cherry picked from commit 0df8fdd)
jcipar
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #23337.
Merge conflict due to unrelated changes in
cluster_config_test.py.Closes #23356
Backports Required
Release Notes