Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-7039] schema_registry: Tolerate null metadata and ruleSet #23044

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[CORE-7039] schema_registry: Tolerate null metadata and ruleSet #23044

merged 1 commit into from
Aug 27, 2024

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Aug 23, 2024

In the absence of supporting these features, it's friendly to tolerate clients that explicitly set them to null, such as the latest DotNet client.

Fixes #23038

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • Schema Registry: Tolerate null metadata and ruleSet when registering or querying a schema

@BenPope
schema_registry: Tolerate null metadata and ruleSet
55bd576 
In the absence of supporting these features, it's friendly to tolerate
clients that explicitly set them to null, such as the latest DotNet
client.

Fixes redpanda-data#23038

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Aug 23, 2024
@BenPope BenPope requested a review from a team August 23, 2024 20:36
@BenPope BenPope self-assigned this Aug 23, 2024
@BenPope BenPope requested review from michael-redpanda and oleiman and removed request for a team August 23, 2024 20:36
oleiman
oleiman approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

src/v/pandaproxy/schema_registry/requests/post_subject_versions.h Show resolved Hide resolved
tests/rptest/tests/schema_registry_test.py Show resolved Hide resolved
@BenPope
Copy link
Member Author

BenPope commented Aug 23, 2024 •
edited
Loading

CI Failures are fixed by:

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Aug 24, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53501#01918228-6d05-4a2f-be44-5ef29c75b5f8

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53501#01918228-6d08-42e9-a913-a149535273e9

@BenPope
Copy link
Member Author

BenPope commented Aug 24, 2024

Ci Failures:

@michael-redpanda michael-redpanda merged commit 36217e6 into redpanda-data:dev Aug 27, 2024
16 of 19 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

This was referenced Aug 27, 2024
Closed
Merged
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@michael-redpanda michael-redpanda michael-redpanda approved these changes

@andijcr andijcr andijcr approved these changes

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema Registry doesn't work with latest DotNet client
5 participants
@BenPope @vbotbuildovich @andijcr @oleiman @michael-redpanda