[v24.2.x] cluster: Parse unknown self-test checks
#22922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only applied to `[v24.2.x]` and `[dev]` branches. See redpanda-data#22778 for change to `[v24.1.x]`. Also bumps `serde::version` of `start_test_request` to 2. This `serde::version<>` needed bumping to `serde::version<2>`, since `serde::version<0>` is the version of `start_test_request` with just `diskcheck_opts` and `netcheck_opts`, while `serde::version<1>` is the version with `unknown_checks` added, and `serde::version<2>` needs to reflect the most recently added `cloudcheck_opts`. Also, re-order fields in `start_test_request` to allow serde to work correctly in the interim. (cherry picked from commit 1f8e4cd)
In the case that the controller node which originally parsed the `rpk cluster self-test start` command was of a lower version than the follower nodes in a cluster, it is possible that some tests may not have been recognized by the controller, and instead pushed back into `start_test_request.unknown_checks`. On these upgraded follower nodes, they will attempt to parse any `unknown_checks`, in case they recognize them. This is currently only affecting the `cloudcheck` self-test, in mixed clusters with versions before and after `v24.2.x`. However, any future self-tests that get added to `redpanda` should also add their case to `parse_unknown_checks()` for completion's sake. (cherry picked from commit 016487c)
This struct was erroneously altered by adding a new field without bumping the `serde::version<>`. This struct also lacks a `serde_fields()` implementation, so adding the new field anywhere but the end of the structure is an issue for serialization/deserialization. Update it by moving the field to the end of the struct, and bumping the `serde::version<>` to 1. (cherry picked from commit fb3fd6d)
NFCs in this commit. (cherry picked from commit cefe877)
(cherry picked from commit a33abd7)
Clean up the `self_test_backend` and `admin/server` parse sites for self-test JSON parsing by adding `parse_self_test_checks()`. This will now be the function called from `server::self_test_start_handler()` as well as `self_test_backend::do_start_test()`. Also, rename `unknown_check` to `unparsed_check` for clarity. These unparsed checks are still considered "unknown" if they exist by the end of the self-test. (cherry picked from commit bbd6445)
WillemKauf
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22831