Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-13192) fix(network-manager): add "After" dependency on dbus.service #89

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Jul 17, 2024

During shutdown, there is no ordering dependency between the nm-initrd service
and the D-Bus daemon, and so the latter can be stopped before. This causes
issues to NetworkManager, especially when team interfaces are present because
NM will see teamd dropping from the bus and will try to reactivate the
connection.

Add a "After" dependency to make sure the D-Bus daemon is stopped after NM on
shutdown.

(Cherry-picked commit: 1b7d83110741560f26027fbd9435763eef56935a)

Resolves: RHEL-13192

During shutdown, there is no ordering dependency between the nm-initrd service
and the D-Bus daemon, and so the latter can be stopped before. This causes
issues to NetworkManager, especially when team interfaces are present because
NM will see teamd dropping from the bus and will try to reactivate the
connection.

Add a "After" dependency to make sure the D-Bus daemon is stopped after NM on
shutdown.

(Cherry-picked commit: 1b7d83110741560f26027fbd9435763eef56935a)

Resolves: RHEL-13192
@pvalena pvalena added the bug Something isn't working label Jul 17, 2024
@pvalena pvalena self-assigned this Jul 17, 2024
@github-actions github-actions bot changed the title fix(network-manager): add "After" dependency on dbus.service (RHEL-13192) fix(network-manager): add "After" dependency on dbus.service Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Commit validation

Tracker - RHEL-13192

The following commits need an inspection

commit note
c07aeab - fix(network-manager): add "After" dependency on dbus.service Missing upstream reference ‼️

Tracker validation

Failed

🔴 Tracker RHEL-13192 has product rhel-9.1.0 but desired product is one of Red Hat Enterprise Linux 9,CentOS Stream 9,rhel-9.0.0,rhel-9.0.0.z,rhel-9.2.0,rhel-9.2.0.z,rhel-9.3.0,rhel-9.3.0.z,rhel-9.4,rhel-9.4.z,rhel-9.5,rhel-9.5.z,rhel-9.6,rhel-9.6.z,rhel-9.7,rhel-9.7.z,rhel-9.8,rhel-9.8.z,rhel-9.9,rhel-9.9.z,rhel-9.10,rhel-9.10.z

Success

🟢 Tracker RHEL-13192 has set desired component: dracut
🟢 Tracker RHEL-13192 has been approved


Pull Request validation

Failed

🔴 Failed or pending checks - testing-farm:centos-stream-9-x86_64[failure]
🔴 Review - Missing review from a member

@pvalena
Copy link
Contributor Author

pvalena commented Jul 27, 2024

LGTM.

@pvalena pvalena merged commit 79fbe41 into redhat-plumbers:main Jul 27, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants