[Nette] forms setRequired(false)

[TomasVotruba]

Closes #27

What is the function?

I really didn't get it from the forum, so at the moment it works like this:

Find on variable of Nette\Application\UI\Form type:

->addCondition($form::FILLED)

and replace it by:

->setRequired(false)

Could you confirm/help me with that @dg && @petrvacha?

[dg]

Just note: in specific cases, this may be an incompatible change.

[TomasVotruba]

I don't actually understand it... this is just first example.

Could you provide cases to make it compatible?

[dg]

I mean rare cases. For example:

$form->addText('name')
    ->addCondition($form::FILLED)
        ->addRule(...)
        ->addRule(...);

$form['name']
        ->addRule(...); // this rule is called regardless of whether it is filled in (Nette 2.4 triggers warning here that will force you to decide whether the field is required or not)

Automatically changed code:

$form->addText('name')
    ->setRequired(false)
    ->addRule(...)
    ->addRule(...);

$form['name']
        ->addRule(...); // now is this rule called only when input is filled (no warning is triggered)

[TomasVotruba]

Thanks. I haven't seen such use case yet.

So there should be added another refactoring, that adds setRequired() if there is only addRule()?

[dg]

Yes, when there is addRule(), there must be setRequired().

But every such changes must be checked by the programmer, because in some cases it can change the function.

[TomasVotruba]

Sure, the aim is to keep programmer out of manually work and keep only checking. Something like code review.

Thanks, I will look on that later