Formatting bug for Symfony Constraints

[ghost]

Bug Report

Subject	Details
Rector version	0.8.x-dev@0a8bef3
Installed as	docker latest image

 <?php

 use Symfony\Component\Validator\Constraints as Assert;

 class User
 {
     /**
-     * @Assert\Email(message = "email.email")
+     * @Assert\Email(message=email.email)
      */
     private $email;
 }

Expected Behaviour

Rector should not touch it.

SF 4.4 application. My rector.yaml:

services:
    Rector\Php74\Rector\Property\TypedPropertyRector:
    Rector\Php74\Rector\Property\RestoreDefaultNullToNullableTypePropertyRector:

parameters:
    auto_import_names: true
    import_short_classes: false
    autoload_paths:
        - /project/config/bootstrap.php 

Can't run demo, getting Function 'mail()' is not allowed..

[TomasVotruba]

Can't run demo, getting Function 'mail()' is not allowed.

That's correct. The code needs to be complete. Include it to the analysed code:

function mail() {}

[ghost]

Getting Fix PHP syntax wherever I put this function (inside class, outside class).

[TomasVotruba]

Could you share the link to that demo?

[ghost]

I can't. It's still /demo when I press Process. Form is filled as in the picture above.
Edit: Same after adding function mail() {};

[TomasVotruba]

I see...

New I remember! The @Email annotation is using mail() function, which is invoked for some reason.

If we'd allow mail() on demo, it could be exploited. Thus it's forbidden.

Just use different "safe" annotation: https://getrector.org/demo/2d619dcb-71bd-48ed-a212-8d644df3614f#result

[TomasVotruba]

As for annotation formatting, there is often nothing we can do, as there is no tool to preserve format.

If the behavior doesn't change, we close it as won't fix.

[ghost]

Actually NotNull cannot be used as $email should be also validated with @Email. I wonder why rector even touches this line (especially with this configuration).
This will happen only with @Email annotation or there are plenty of others annotations that will couse this buggy formatting?
Can I skip this line with @Email somehow?

[TomasVotruba]

Actually NotNull cannot be used as $email

It can. It's not relevant for this example. It is basically "any annotation class".

Can I skip this line with @Email somehow?

The solution is to correct formatting in whole project, e.g. with some regex. Anything else will disable Rector rules.

[TomasVotruba]

Related to and duplicate of #4334