[DependencyInjection] Extract GetByTypeMethodCallToConstructorInjectionRector to make migration smoother #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-get-to-inject
branch
from
2d57041 to
0a162c9
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-get-to-inject
branch
from
0a162c9 to
53cc027
Compare
…onRector to make migration smoother
TomasVotruba
force-pushed
the
tv-get-to-inject
branch
from
53cc027 to
9adccc8
Compare
samsonasik
reviewed
Dec 1, 2024
|
|
||
| final class SomeCommand extends Controller | ||
| { | ||
| public function __construct(private SomeType $someType) |
There was a problem hiding this comment.
min php version 8.0 is needed for promotion property
There was a problem hiding this comment.
I see, it already handled at $this->classDependencyManipulator->addConstructorDependency($node, $propertyMetadata) that verify php version 👍
This was referenced Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.