📦 Ignore .phpstorm.meta.php because this is not PHP file
#6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 15, 2024
| // this file cannot be interpreted as PHP file | ||
| // https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html#expected-arguments | ||
| ->notName('.phpstorm.meta.php') | ||
| ; |
There was a problem hiding this comment.
I think we should not need to enable dot files by default, eg:
public function withRootFiles(bool $includeDotFiles = false)ensure be safe by default, while still hardcoded this obvious .phpstorm.meta.php so no change by default.
Then you can add condition:
if ($includeDotFiles) {
$rootPhpFilesFinder->ignoreDotFiles(false);
}There was a problem hiding this comment.
I'm OK with all options (enable for all dotfiles except known risky, enable for known dotfiles, provide an argument, etc)
There was a problem hiding this comment.
I am for:
- disable by default (make optional)
- still exclude
.phpstorm.meta.phpas known risky
There was a problem hiding this comment.
@TomasVotruba, what do you think about this?
|
Let's merge to keep forward and ensure other PR on sync not hung up on run rector. Let's see how next improvement will happen |
|
Thank you @andrew-demb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6593
Refs: #6593 (comment)