[DeadCode] Skip @template tag on RemoveUselessVarTagRector

[samsonasik]

Fixes rectorphp/rector#8870

[samsonasik]

@dragosprotung this can be tweak solution, but it will cause invalid skipped real non existing object type, see fixture /~https://github.com/rectorphp/rector-src/pull/6396/files#diff-d9d0d07e6a9125b667f68974544d4c6567c6b31da986c9644d725c188257f378

There was 1 failure:

1) Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\RemoveUselessVarTagRectorTest::test with data set #3 ('/home/runner/work/rector-src/...hp.inc')
Failed on fixture file "non_existing_object.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 final class NonExistingObject
 {
+    /** @var SomeNonExistingObject */
     private Properties|null $properties;

[dragosprotung]

I don't know if this is something that is acceptable. If the referenced type is somehow not discoverable by Rector, is the job of DeadVarTagValueNodeAnalyzer to remove the tag ?

Also, could we not check if $docType is a template NonExistingObjectType->getClassName() = TType?

[samsonasik]

The patch seems needs to be in ObjectTypeSpecifier to locate @template if exists before marking as NonExistingObjectType

rector-src/rules/TypeDeclaration/PHPStan/ObjectTypeSpecifier.php

Lines 58 to 70 in d415260

	// probably in same namespace
	if ($scope instanceof Scope) {
	$namespaceName = $scope->getNamespace();
	if ($namespaceName !== null) {
	$newClassName = $namespaceName . '\\' . $className;
	if ($this->reflectionProvider->hasClass($newClassName)) {
	return new FullyQualifiedObjectType($newClassName);
	}
	}
	}
	// invalid type
	return new NonExistingObjectType($className);

[dragosprotung]

Yes, you might be right. Unfortunatly I do not have enought knowlage of PHPStan to find out if the type is a template or not.

[dragosprotung]

Would it be a problem if the unknown type is not removed ?

[samsonasik]

@template tag should be detected, unknown type can be just typo missing FQCN on class name, which should be removed as pointed to invalid class target.

[samsonasik]

Fixed by get @template from ClassReflection 02b566a

current limitation is currently only detect single @template that can be improved in separate PR when possible :)

[samsonasik]

It seems cause invalid rectify 366194b , I will check more :)

[samsonasik]

should be fixed now :)

[dragosprotung]

I don't know if this is something that is acceptable. If the referenced type is somehow not discoverable by Rector, is the job of DeadVarTagValueNodeAnalyzer to remove the tag ?

Also, could we not check if $docType is a template NonExistingObjectType->getClassName() = TType?

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)