[NodeTypeResolver] Handle optional array shape on native function like with ArrayDimFetch #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
Fixed 🎉 /cc @staabm |
staabm
reviewed
Sep 21, 2023
|
|
||
| $type = $scope->getType($arrayDimFetch); | ||
|
|
||
| if (! $arrayDimFetch->dim instanceof String_) { |
There was a problem hiding this comment.
This looks fishy. We will surely find array shapes with int keys
There was a problem hiding this comment.
I think that's need another fixture for next improvement 👍
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5060