Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip used by trait inside Closure on RemoveUnusedPrivateMethodRector #4773

Merged
merged 3 commits into from
Aug 11, 2023
Merged

[DeadCode] Skip used by trait inside Closure on RemoveUnusedPrivateMethodRector #4773

merged 3 commits into from
Aug 11, 2023

Conversation

samsonasik
Copy link
Member

Continue of PR:

Method Call inside Closure can call Method from $this so should be skipped as well.

@samsonasik
Copy link
Member Author

Ref https://3v4l.org/UC2ac

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it;)

@samsonasik samsonasik merged commit 130f07b into main Aug 11, 2023
@samsonasik samsonasik deleted the skip-used-by-trait-closure branch August 11, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik