Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Allow change multiple methods on AddParamTypeDeclarationRector #4727

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

samsonasik
Copy link
Member

Previosly, the if (! $this->hasChanged) { inside loop cause stop when passed method is not changed early, this change apply check if (! $this->hasChanged) { after the loop instead to allow by passed not changed method, then continue apply change on changed target methods.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit b98df68 into main Aug 9, 2023
@samsonasik samsonasik deleted the change-multiple branch August 9, 2023 06:37
@staabm
Copy link
Contributor

staabm commented Aug 9, 2023

nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants