added $kind param to TypeMapperInterface->mapToPHPStanPhpDocTypeNode()
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which allows to differentiate the returned type based on the used location
staabm
commented
Jun 26, 2021
Comment on lines
29
to
31
| if ($kind === 'return') { | ||
| return new IdentifierTypeNode('never'); | ||
| } |
There was a problem hiding this comment.
this line implements the actual motivation of this PR - everything else is just a mechanical change because the interface changed
staabm
commented
Jun 26, 2021
|
After a few iterations I realized that a @TomasVotruba this PR is ready to review |
packages/PHPStanStaticTypeMapper/TypeMapper/NeverTypeMapper.php
Outdated
Show resolved
Hide resolved
|
@TomasVotruba this is ready for another round |
|
Thank you 👍 I was looking for a test for Lets ship it! |
yep, this is coming with #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which allows to differentiate the returned type based on the used location.
this is required to add a proper
@return neverhandling as we are building it in #296