[CodingStyle] Skip new line on ConsistentPregDelimiterRector

[samsonasik]

Given the following code:

        $content = 'some texte';
        $parts = preg_split("/(\r\n|\n|\r){2}/", $content);

currently produce:

         $content = 'some texte';
-        $parts = preg_split("/(\r\n|\n|\r){2}/", $content);
+        $parts = preg_split("#(
+|
){2}#", $content);

which should be fixed.

This PR try to fix it.

Fixes rectorphp/rector#6868

[samsonasik]

It seems because of INNER_REGEX constant doesn't use u modifier:

rector-src/rules/CodingStyle/Rector/FuncCall/ConsistentPregDelimiterRector.php

Line 38 in 00b9f8f

private const INNER_REGEX = '#(?<content>.*?)(?<close>[imsxeADSUXJu]*)$#s';

however, changing to u modifier will break existing fixture UpdateMultilinePcreExtendedPattern

rector-src/rules-tests/CodingStyle/Rector/FuncCall/ConsistentPregDelimiterRector/Fixture/update_multiline_pcre_extended_pattern.php.inc

Lines 5 to 19 in 00b9f8f

	class UpdateMultilinePcreExtendedPattern
	{
	public function run()
	{
	$file = preg_replace('/^(
	test
	)/x', '', $file);
	$file = preg_replace('#^(
	test
	)#x', '', $file);
	}
	}
	?>

     public function run()
     {
-        $file = preg_replace('#^(
+        $file = preg_replace('/^(
             test
-        )#x', '', $file);
+        )/x', '', $file);
 
         $file = preg_replace('#^(
             test
-        )#x', '', $file);
+        )\\\\\\\\\\\\\\\\\#x', '', $file);

[samsonasik]

Fixed 🎉 , handled with compare PCRE_UTF8 (u) value with PCRE_DOTALL (s) value, if not equal, check if it has \r or \n

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Thank you 👍