[Privatization] Skip protected property used in parent class on PrivatizeFinalClassPropertyRector #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Dec 15, 2021
|
|
||
| $methods = $classLike->getMethods(); | ||
| foreach ($methods as $method) { | ||
| $isFound = (bool) $this->betterNodeFinder->findFirst((array) $method->stmts, function (Node $subNode) use ($propertyName): bool { |
There was a problem hiding this comment.
I tried using findFirstInFunctionLikeScoped() which check only in scoped of classmethod, but seems fails got parent type, it possibly due to classmethod of the class pulled from AstResolver which make the information of parent is not filled, so I used findFirst() instead.
samsonasik
force-pushed
the
close-1489
branch
from
65ad8c4 to
ec3b58c
Compare
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1489