Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for method signatures with default value #1450

Closed
wants to merge 3 commits into from
Closed

Test for method signatures with default value #1450

wants to merge 3 commits into from

Conversation

norgeindian
Copy link
Contributor

No description provided.

@norgeindian norgeindian mentioned this pull request Dec 10, 2021
Closed
@samsonasik
Copy link
Member

I checked locally, it seems it needs some tweak as there is internal php-parser error like at #1431 (comment)

samsonasik added a commit that referenced this pull request Dec 10, 2021
@samsonasik
Fixes #1450
d3f214e
@samsonasik samsonasik mentioned this pull request Dec 10, 2021
Merged
@samsonasik
Copy link
Member

@norgeindian I cherry-picked your commit at PR #1452

TomasVotruba pushed a commit that referenced this pull request Dec 10, 2021
@samsonasik @norgeindian
[Php80] Handle param with default value on AddParamBasedOnParentClass…
8d6eb87 
…MethodRector (#1452)

* Add source with default value

* Add fixture for default value

* Rename fixture

* Fixes #1450

Co-authored-by: Ole Schäfer <ole@customgento.com>
@TomasVotruba
Copy link
Member

@norgeindian Thank you for the test fixture 👍

@norgeindian
Copy link
Contributor Author

@TomasVotruba , @samsonasik , thanks, that seems to work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norgeindian @samsonasik @TomasVotruba