Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Replace deprecated danielstjules/stringy with Symfony\String #1425

Merged
merged 2 commits into from
Dec 8, 2021
Merged

[DX] Replace deprecated danielstjules/stringy with Symfony\String #1425

merged 2 commits into from
Dec 8, 2021

Conversation

TomasVotruba
Copy link
Member

  • replacing with Symfony\String
  • try removing dim fetch rename

@TomasVotruba TomasVotruba changed the title tv remove stringy [DX] Replace deprecated danielstjules/stringy with Symfony\String Dec 8, 2021
@TomasVotruba TomasVotruba force-pushed the tv-remove-stringy branch 6 times, most recently from c131e91 to b52cc90 Compare December 8, 2021 08:12
@TomasVotruba TomasVotruba merged commit 7053e9a into main Dec 8, 2021
@TomasVotruba TomasVotruba deleted the tv-remove-stringy branch December 8, 2021 08:52
@samsonasik
Copy link
Member

@TomasVotruba typo3-rector seems needs to be updated as well /~https://github.com/sabbelasichon/typo3-rector/blob/9de803d00a9485cec79bb364e52eb85ab3613e03/src/Helper/StringUtility.php#L7

@samsonasik
Copy link
Member

@TomasVotruba stringy seems still included /~https://github.com/rectorphp/rector/blob/main/vendor/danielstjules/stringy/src/Stringy.php and the #[\ReturnTypeWillChange] change is gone, probably due to typo3-rector still uses it.

@samsonasik samsonasik mentioned this pull request Dec 8, 2021
Merged
@TomasVotruba
Copy link
Member Author

Thanks for checking!

I also just removed it from Symplify, so maybe the tagging it is needed.

@samsonasik
Copy link
Member

@TomasVotruba I created issue on typo3-rector for it sabbelasichon/typo3-rector#2745

@samsonasik
Copy link
Member

@TomasVotruba it seems stringy still required in rector-symfony,. ref /~https://github.com/rectorphp/rector-symfony/blob/5a24edfe3cf6f66766cbf2bc7eddc7340f06a800/composer.json#L9

@TomasVotruba
Copy link
Member Author

Thank you

mallardduck added a commit to mallardduck/rector-src that referenced this pull request Dec 9, 2021
@mallardduck
Merge branch 'main' into php82-remove-allow-dynamic-attribute
ee69839 
* main: (50 commits)
  Add SimpleStaticType for return type completion (rectorphp#1441)
  [Transform] Move ReservedFnFunctionRector from Php74 to Transform namespace (rectorphp#1423)
  [Php80] Add AddParamBasedOnParentClassMethodRector (rectorphp#1431)
  [DowngradePhp80] Add DowngradeRecursiveDirectoryIteratorHasChildrenRector (rectorphp#1440)
  [Scoped] Skip symfony console Event and EventListener and exclude in parallel-lint (rectorphp#1439)
  [Scoped] Fix exclude symfony/console/Tester (rectorphp#1438)
  [Scoped] Require symfony-eventdispatcher on build (rectorphp#1437)
  [Scoped] Fix downgrade error on symfony/console/Tester (rectorphp#1436)
  [Scoped] Fix downgrade error on symfony/Event* (rectorphp#1435)
  [TypeDeclaration][Php 8.1] Add Closure support to ReturnNeverTypeRector (rectorphp#1434)
  [composer] require own rector packages in dev-main, to avoid endless tagging (rectorphp#1433)
  [TypeDeclaration][Php 8.1] Do not change parent function to never on ReturnNeverTypeRector (rectorphp#1432)
  [DX] Improve configuration objects + allow Symfony 6 (rectorphp#1430)
  Require Symplify 10.0.2, remove stringy deprecated package from installed dependencies 🎉 (rectorphp#1429)
  Bump to Symplify 10.0.1 stable (rectorphp#1428)
  [DX] Decouple AssignVariableNameResolver (rectorphp#1427)
  [DowngradePhp80] Fix DowngradeThrowExprRector on property fetch to use not isset (rectorphp#1426)
  [DX] Replace deprecated danielstjules/stringy with Symfony\String (rectorphp#1425)
  [Alternative][Validation] Add AllowEmptyConfigurableRectorInterface interface for alternative to not show warning on allowed rector rule to have default fallback config (rectorphp#1422)
  [DX] Less addNodeAfterNode() methods (rectorphp#1421)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @samsonasik