[8.2] make AddAllowDynamicPropertiesAttributeRector configurable #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
commented
Dec 4, 2021
.../Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector/config/configured_rule.php
Show resolved
Hide resolved
samsonasik
reviewed
Dec 5, 2021
| @@ -7,5 +7,10 @@ | |||
|
|
|||
| return static function (ContainerConfigurator $containerConfigurator): void { | |||
| $services = $containerConfigurator->services(); | |||
| $services->set(AddAllowDynamicPropertiesAttributeRector::class); | |||
| $services->set(AddAllowDynamicPropertiesAttributeRector::class) | |||
There was a problem hiding this comment.
please add 1 more test class with no config to fallback to change all classes, even without namespace
samsonasik
reviewed
Dec 9, 2021
rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 9, 2021
Comment on lines
11
to
15
| ->call('configure', [[ | ||
| AddAllowDynamicPropertiesAttributeRector::TRANSFORM_ON_NAMESPACES => [ | ||
| '*\Fixture\Process\*' | ||
| ] | ||
| ]]); |
There was a problem hiding this comment.
can be changed to:
Suggested change
| ->call('configure', [[ | |
| AddAllowDynamicPropertiesAttributeRector::TRANSFORM_ON_NAMESPACES => [ | |
| '*\Fixture\Process\*' | |
| ] | |
| ]]); | |
| ->configure( | |
| [ | |
| '*\Fixture\Process\*' | |
| ] | |
| ); |
There was a problem hiding this comment.
We should have probably PHPStan rule for this one 👍
mallardduck
force-pushed
the
configurable-allow-dynamic-props
branch
from
9f68afa to
c5e362c
Compare
samsonasik
approved these changes
Dec 10, 2021
|
Thanks again 👏 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the talk in #1225 this expands on that by making it configurable for namespaces.