-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dep] Update to php 8.1 requirement (manual) #1374
Conversation
…s syntax update usage and downgrade rule for it
0221fd4
to
48e199c
Compare
@TomasVotruba all green 🎉 it is ready for review. Note: the pending CI PHP 8.0 are probably cache or need you to disable it? |
It's because of requried names of jobs that must pass. Unfortunatelly Github sees thems as string, it's based on workflow name. |
Instead, the code using these enums should be upgraded from interface MinPhpVersionInterface
{
- public function provideMinPhpVersion(): int;
+ public function provideMinPhpVersion(): PhpVersion;
}
It should be handled in separated PR, maybe via a new Rector rule. |
config/set/php81.php
Outdated
return static function (ContainerConfigurator $containerConfigurator): void { | ||
$services = $containerConfigurator->services(); | ||
$services->set(ReturnNeverTypeRector::class); | ||
$services->set(MyCLabsClassToEnumRector::class); | ||
//$services->set(MyCLabsClassToEnumRector::class); | ||
$services->set(MyCLabsMethodCallToEnumConstRector::class); | ||
$services->set(FinalizePublicClassConstantRector::class); | ||
$services->set(ReadOnlyPropertyRector::class); | ||
$services->set(SpatieEnumClassToEnumRector::class); | ||
//$services->set(SpatieEnumClassToEnumRector::class); | ||
$services->set(Php81ResourceReturnToObjectRector::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be included in set so others can use them, but be skipped in our rector.php
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 0ee361c
…nfig set, but skip in rector.php
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Thank you 👍 |
@TomasVotruba this is split of #1364 with manual change only with teskipped:
MyCLabsClassToEnumRector
andSpatieEnumClassToEnumRector
as it makeEnum
syntax upgrade needs to be skipped as it changePhpVersion
class that extends :which will need update currently manually of its usage:
and it seems cause change
also other Enums, eg
ObjectReference
andApplicationPhase
manually:and we may need to create a downgrade rule for it to keep working on scoping.
I commented the rules at 99fa67b