Fix issue of parsing PHP 8 sources on PHP 7.x

[ondrejmirtes]

This fixes rectorphp/rector#6779

/cc @samsonasik @TomasVotruba

[samsonasik]

@ondrejmirtes I confirm that it works 🎉 Thank you

[TomasVotruba]

Awesome, thank you 👏

[TomasVotruba]

Related bug: rectorphp/rector#6799

We'll need 2 parsers:

• one for user's code that respects their PHP version.
• one for the stubs parsing

[TomasVotruba]

@ondrejmirtes Any ideas how to make those 2 parser like PHPStan has? I'm trying to play with neon syntax, but I keep failing as I never used it without autowiring.

[ondrejmirtes]

@TomasVotruba You need a PathRoutingParser like PHPStan has (/~https://github.com/phpstan/phpstan-src/blob/master/src/Parser/PathRoutingParser.php), but probably not exactly the same one, but custom for your needs.

This is how it's configured: /~https://github.com/phpstan/phpstan-src/blob/ce0b04308d4761f6efd8ce3fec90be59e1197ced/conf/config.neon#L1744-L1750

[TomasVotruba]

Not sure how to configure it and how that would help.

So far I think the problem is the default parser is used for stubs that are in PHP 8.
But in analysis we need PHP based default rich parser.

[ondrejmirtes]

That's exactly how PathRoutingParser can help you.

[TomasVotruba]

Any ideas how exacly it should be configured? What does "path routing" mean?

This parses PHP 7.4 code, but fails to parse stubs:

#parameters:
#    phpVersion: 80100

services:
    defaultAnalysisParser:
        factory: @cachedRectorParser
        arguments!: []

    cachedRectorParser:
        class: PHPStan\Parser\CachedParser
        arguments:
            originalParser: @rectorParser
            cachedNodesByStringCountMax: %cache.nodesByStringCountMax%
        autowired: no

    rectorParser:
        class: PHPStan\Parser\RichParser
        arguments:
            parser: @currentPhpVersionPhpParser
            lexer: @currentPhpVersionLexer
        autowired: no

    pathRoutingParser:
        class: PHPStan\Parser\PathRoutingParser
        arguments:
            currentPhpVersionRichParser: @php8PhpParser
            currentPhpVersionSimpleParser: @php8PhpParser
            php8Parser: @php8Parser
        autowired: false

[ondrejmirtes]

This calls for a phone call again :) I have time on Friday.

[TomasVotruba]

It fails on FileTypeMapper that is using defaultAnalysisParser (PHP 7.4) /~https://github.com/phpstan/phpstan-src/blob/ce0b04308d4761f6efd8ce3fec90be59e1197ced/conf/config.neon#L864-L867

But it seems Nette DI is unable to override anonymous services :/

	-
		class: PHPStan\Type\FileTypeMapper
		arguments:
-			phpParser: @defaultAnalysisParser
+			phpParser: @pathRoutingParser

↓

PHP Fatal error:  Uncaught _PHPStan_c862bb974\Nette\DI\ServiceCreationException: 
Multiple services of type PHPStan\Type\FileTypeMapper found: 0114, 0246 in phar:///var/www/rector-syntax-bug/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Autowiring.php:53

[ondrejmirtes]

The defaultAnalysisParser must be pathRoutingParser, that's the whole point. And you should use it to route parser requests either to current version PHP parser (analysed code, dependencies), or to PHP 8 parser (stubs).

[TomasVotruba]

I'd prefer to solve it now :D it seems extreemely hard for such a simple task.
I'll give it couple more hours. If I fail, we can call.

[TomasVotruba]

Something like this?

services:
    pathRoutingParser:
        class: PHPStan\Parser\PathRoutingParser
        arguments:
            currentPhpVersionRichParser: @rectorParser
            currentPhpVersionSimpleParser: @rectorParser
            php8Parser: @php8Parser
        autowired: false

    rectorParser:
        class: PHPStan\Parser\RichParser
        arguments:
            parser: @currentPhpVersionPhpParser
            lexer: @currentPhpVersionLexer
        autowired: no

[ondrejmirtes]

I'd prefer if you wrote your own PathRoutingParser, the one from PHPStan is too complex and unsuitable for your needs.

You also need to include:

    defaultAnalysisParser:
        factory: @pathRoutingParser
        arguments!: []

[TomasVotruba]

I'd prefer if you wrote your own PathRoutingParser, the one from PHPStan is too complex and unsuitable for your needs.

If I understand what it does and why, I'll try 👍

It looks that this - #1184 (comment) - works for both fixture and CI in this repository.

You also need to include:

I'll try

[TomasVotruba]

The work is done in #1480

[TomasVotruba]

Looks good, the tests pass here, the repository with bug is fixed too: /~https://github.com/cjunge-work/rector-syntax-bug/pull/3

Thanks @ondrejmirtes 👍 👏

I can sleep in peace today :)

[cjunge-work]

Thank you @TomasVotruba!!! 🍻