[CodeQuality] Skip Variable may be immutable via New_ or Clone_ on SimplifyUselessVariableRector #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
patch-1
branch
4 times, most recently
from
b200b37 to
2ba1f5a
Compare
|
There is strange error in test for different rule: 1) Rector\Tests\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector\NormalizeNamespaceByPSR4ComposerAutoloadRectorTest::test with data set #4 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
69
Undefined array key 29 |
|
The error in |
|
rebased. |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
…tion with DateTimeImmutable object Rector should not remove a local variable, otherwise, time is not set in the returned object. Issue rectorphp/rector#6769 Based on https://getrector.org/demo/1ec35a54-0df0-69b8-ab06-f7704eb531f0
This reverts commit 2ba1f5a.
|
rebased. |
|
I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1059 Fixes rectorphp/rector#6769 Always check variable is assigned with
New_orClone_to ensure the assigned value is not immutable.