Add project: use an instance variable to avoid 500

[humitos]

Closes readthedocs/ext-theme#477

[stsewd]

Looks like you can use a condition_dict class attribute to define when to skip a step https://django-formtools.readthedocs.io/en/latest/wizard.html#formtools.wizard.views.WizardView.condition_dict.

[humitos]

I implemented it using condition_dict. It's not perfect because that method is called multiple times and that's kind of an issue for us due that we perform external API calls.

[stsewd]

It's not perfect because that method is called multiple times and that's kind of an issue for us due that we perform external API calls.

Maybe it was fixed in the latest releases? Or maybe this is an open bug jazzband/django-formtools#134

[humitos]

We can improve/fix that bug later. I want to merge this because a lot of users are hitting this issue when importing projects.

Let's fix the immediate problem first and then we can polish it.

[humitos]

Based on this comment jazzband/django-formtools#134 (comment), the problem is not solved in master since they are still re-calculating all property by calling get_form_list().

[humitos]

Failing test looks unrelated, FAILED readthedocs/rtd_tests/tests/test_domains.py::FormTests::test_invalid_domains - ValueError: 'special' does not appear to be an IPv4 or IPv6 address

[stsewd]

I still think we should try to update this dependency as well.

[humitos]

Yes. I'm doing that in another branch already 👍🏼