Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle #82

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Update build.gradle #82

merged 1 commit into from
Oct 10, 2022

Conversation

UgurGumushan
Copy link
Contributor

@UgurGumushan UgurGumushan commented Mar 14, 2022

This PR adds safeExtGet function to use sdk versions from the root project

Resolves: Issue 77

If the root project uses a minSdkVersion which is higher than 16, building the root project which uses react native (com.facebook.react:react-native:0.65.1) fails

The error message:

> Task :react-native-community_progress-bar-android:processDebugAndroidTestManifest FAILED
[androidx.vectordrawable:vectordrawable-animated:1.0.0] /Users/UgurGumushan/.gradle/caches/transforms-3/f66d8f3946e5dc0709e169eabc5d4aea/transformed/vectordrawable-animated-1.0.0/AndroidManifest.xml Warning:
        Package name 'androidx.vectordrawable' used in: androidx.vectordrawable:vectordrawable-animated:1.0.0, androidx.vectordrawable:vectordrawable:1.0.1.
/Users/UgurGumushan/Code/kontist/app/node_modules/@react-native-community/progress-bar-android/android/build/intermediates/tmp/manifest/androidTest/debug/manifestMerger8441565954767347173.xml:5:5-74 Error:
        uses-sdk:minSdkVersion 16 cannot be smaller than version 21 declared in library [com.facebook.react:react-native:0.65.1] /Users/UgurGumushan/.gradle/caches/transforms-3/154779808e92101f84642acdf5bc7bdf/transformed/jetified-react-native-0.65.1/AndroidManifest.xml as the library might be using APIs not available in 16
        Suggestion: use a compatible library with a minSdk of at most 16,
                or increase this project's minSdk version to at least 21,
                or use tools:overrideLibrary="com.facebook.react" to force usage (may lead to runtime failures)

add safeExtGet function to use sdk versions from the root project
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar merged commit 1f8a839 into react-native-progress-view:master Oct 10, 2022
@StebanDev
Copy link

@Naturalclar you probably forgot to release this fix 😅

@Naturalclar
Copy link
Member

@StebanDev thanks for the reminder! just published update with this fix as v1.0.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take compileSdkVersion from root project
3 participants