Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove global-cli #1540

Merged
merged 2 commits into from
Feb 2, 2022
Merged

chore: remove global-cli #1540

merged 2 commits into from
Feb 2, 2022

Conversation

grabbou
Copy link
Member

@grabbou grabbou commented Feb 1, 2022

Summary:

It's deprecated and is causing us issues with tools since it resides in packages folder alongside other monorepo packages. If necessary, we can move it to a separate package and explicitly archive. So far, I think it can be safely removed, we have legacy branches (such as 6.x) where we can refer to it.

@@ -1,6 +1,6 @@
{
"name": "@react-native-community/cli-platform-android",
"version": "7.0.1",
"version": "7.00.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol mistake

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Next step: remove legacyInit implementation

@grabbou grabbou merged commit 6578485 into master Feb 2, 2022
@grabbou grabbou deleted the feat/remove-global-cli branch February 2, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants