Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make make android signature config more easy. #38

Closed
gengjiawen opened this issue Dec 9, 2018 · 2 comments
Closed

Make make android signature config more easy. #38

gengjiawen opened this issue Dec 9, 2018 · 2 comments

Comments

@gengjiawen
Copy link
Member

This also benefit for user easily set up ci.

  • add debug sig by default
  • make release sig more easily.
@grabbou
Copy link
Member

grabbou commented Dec 10, 2018

Since the HelloWorld template is still in React Native repository - I believe this issue belongs there, right?

The templates folder in this repository is going to be removed soon, when I finish migration between the two repositories.

@gengjiawen
Copy link
Member Author

Yeap, I will handle it there.

@gengjiawen gengjiawen mentioned this issue Dec 15, 2018
Closed
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Dec 17, 2018
@gengjiawen @facebook-github-bot
add basic signature in template (#22665)
63ebbd6 
Summary:
react-native-community/cli#38.
add basic signature in template.
Signature file is the same as RNTester.
pass all current ci.
 [Android] [Feature] - add basic signature in template
Pull Request resolved: #22665

Differential Revision: D13490480

Pulled By: hramos

fbshipit-source-id: 9d0ca4debde2ddbde0d4a611b9b41fc24235314a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grabbou @gengjiawen