Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #230: regression after fix for #197 #231

Merged
merged 1 commit into from
Jan 29, 2020
Merged

fix #230: regression after fix for #197 #231

merged 1 commit into from
Jan 29, 2020

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Jan 29, 2020 •
edited
Loading

  • must call either rimraf.sync or rmdirSync during garbage collection and not use a next parameter
  • remove rimraf wrappers, one can directly call the functions and the wrappers do not make any sense

@silkentrance
fix #230: regression after fix for #197 - must call either rimraf.syn…
3aba7d8 
…c or rmdirSync during garbage collection and not use a next parameter
@silkentrance
Copy link
Collaborator Author

The issue did go unnoticed since all exceptions will be ignored during garbage collection.
And maybe there is a missing test for dirsync and unsafeCleanup. will check.

@silkentrance silkentrance merged commit 61f9a7d into master Jan 29, 2020
@silkentrance silkentrance deleted the gh-230 branch January 29, 2020 19:59
This was referenced Mar 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silkentrance