Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop old NodeJS support #171

Merged
merged 1 commit into from
May 22, 2018
Merged

chore: drop old NodeJS support #171

merged 1 commit into from
May 22, 2018

Conversation

poppinlp
Copy link
Contributor

@poppinlp poppinlp commented May 3, 2018

  • According to issue 158, remove test for node 0.10, 0.12, 4, 5, 7 since they are not alive
  • Use os.tmpdir instead of os-tmpdir package
  • Update devDependencies since we are going to drop support for node 4.x

Haven't change too much :)

@silkentrance
Copy link
Collaborator

@poppinlp nice try 👍

@raszi
Copy link
Owner

raszi commented May 16, 2018 •
edited
Loading

What do you think @silkentrance? I believe it is time to do this.

@silkentrance
Copy link
Collaborator

@raszi I for my part do not see why you shouldn't. We can fix bugs afterwards 👍

@raszi raszi merged commit 310c60f into raszi:master May 22, 2018
@raszi
Copy link
Owner

raszi commented May 22, 2018

Thanks @poppinlp

@raszi raszi changed the title Bump node version chore: drop old NodeJS support May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poppinlp @silkentrance @raszi