Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AppVeyor #110

Merged
merged 1 commit into from
Jan 3, 2017
Merged

chore: add AppVeyor #110

merged 1 commit into from
Jan 3, 2017

Conversation

binki
Copy link
Contributor

@binki binki commented Jan 1, 2017

Fixes #109.

See examples of failed builds at https://ci.appveyor.com/project/binki/node-tmp

@binki
Copy link
Contributor Author

binki commented Jan 2, 2017

The last example build for this PR is https://ci.appveyor.com/project/binki/node-tmp/build/1.0.2 , I noticed that the other branches cause builds even though they don’t have appveyor.yml because I decided to do my test fix attempts on a separate PR.

@@ -0,0 +1,19 @@
# https://www.appveyor.com/docs/lang/nodejs-iojs/

environment:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the line endings?

@binki
Copy link
Contributor Author

binki commented Jan 2, 2017

@raszi Done, see new example build at https://ci.appveyor.com/project/binki/node-tmp/build/1.0.13

@raszi raszi merged commit 88107f9 into raszi:master Jan 3, 2017
@binki binki deleted the add-appveyor branch January 3, 2017 01:52
@silkentrance
Copy link
Collaborator

silkentrance commented Jan 3, 2017

@raszi did you integrate appveyor into github so that it will constantly check the state of the package?
AFAIK the appveyor checks will not be displayed on existing (new) PRs.

@binki
Copy link
Contributor Author

binki commented Jan 4, 2017

@silkentrance it looks like it's set up and just waiting for the first commit to build: https://ci.appveyor.com/project/raszi/node-tmp

@raszi raszi changed the title Add appveyor.yml. chore: add AppVeyor Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add appveyor CI and get tests passing on Windows
3 participants