-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add coverage report #107
Conversation
@raszi The coverage seems off. I think that all spawned sub processes do not collect their data. The data from the sub processes must be merged with the other coverage data. |
👍 Nice work. |
I have prepared an additional commit for you to review and which still requires some more work. This will include all coverage data collected from the child processes that we spawn during the testing process. Additionally, there are still some tests missing, if you look into the generated html report. |
@raszi builds on appveyor are still failing due to an error in the _mocha.CMD. |
It seems as if mocha has nothing to do with that issue: |
1198ad3
to
87b38b0
Compare
Deployment of dependent packages seems to be different on appveyor. I need to run these tests on my windows machine and fix it there. |
302c782
to
6e30849
Compare
The coverage will now be gathered from child processes, too. This also works on windows. Changes had to be made to test/child-process.js that now detects whether it is run under istanbul. The npm test script still needs some work, though. |
6e30849
to
d188536
Compare
npm test script fixed.
Could be better 😱 |
No description provided.