Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm test generates a bunch of uncleaned tmp files #31

Closed
shime opened this issue Sep 10, 2014 · 7 comments
Closed

npm test generates a bunch of uncleaned tmp files #31

shime opened this issue Sep 10, 2014 · 7 comments

Comments

@shime
Copy link
Contributor

shime commented Sep 10, 2014

No description provided.

@raszi
Copy link
Owner

raszi commented Dec 2, 2014

Could you make sure that you closed the file descriptors?

@shime
Copy link
Contributor Author

shime commented Dec 2, 2014

npm test for this project

@raszi
Copy link
Owner

raszi commented Dec 4, 2014

Ohh, I see. Yes, you're right, because of the cleanup tests. I'll make sure to clean up everything.

@silkentrance
Copy link
Collaborator

This also relates to #36 and might be partially fixed by the upcoming PR for that issue. Another issue are the test cases where the temporary folder or file needs to be kept.

@silkentrance silkentrance mentioned this issue Feb 19, 2015
Closed
@silkentrance
Copy link
Collaborator

@raszi You might want to have a look at this...

Still unresolved are using-name tests and some of the spawn tests that IMO fail to clean up after themselves.

@silkentrance
Copy link
Collaborator

It seems as if the error is in the removeCallback. It tries to closeSync the fd first. Failing that, it will not unlink the file.

Will prepare a PR for this.

@silkentrance silkentrance mentioned this issue Feb 21, 2015
Closed
@raszi raszi mentioned this issue Mar 1, 2015
Closed
@silkentrance
Copy link
Collaborator

@raszi With the latest patches this should no longer be an issue, don't you think?

@raszi raszi closed this as completed in ce8e9d4 Aug 14, 2015
raszi added a commit that referenced this issue Aug 14, 2015
@raszi
Merge pull request #60 from coldrye-collaboration/gh-48
aeec5b5 
Replaces gh-31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@raszi @shime @silkentrance