Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of using using DMA with PIO #468

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Add an example of using using DMA with PIO #468

merged 5 commits into from
Feb 18, 2025

Conversation

peterharperuk
Copy link
Contributor

Fixes #467

@peterharperuk peterharperuk added this to the 1.5.2 milestone Jan 26, 2024
lurch
lurch reviewed Jan 26, 2024
View reviewed changes
@kilograham kilograham modified the milestones: 1.5.2, 2.0.1 Aug 20, 2024
@kilograham kilograham modified the milestones: 2.1.0, 2.1.1 Dec 5, 2024
@peterharperuk peterharperuk removed this from the 2.1.1 milestone Feb 5, 2025
@kilograham kilograham self-requested a review February 13, 2025 17:01
@peterharperuk
Copy link
Contributor Author

Currently it just sends a small buffer. To make it more realistic it might be nice to send more data and maybe send and receive on different cores?

@kilograham kilograham added this to the 2.1.1 milestone Feb 13, 2025
kilograham
kilograham previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as is - it shows what to do

@kilograham
remove checks for exclusive irq
377569c 
This is already handled by add_shared_irq_handler() and i think it is more confusing to have it here
@kilograham
A little documetation
ef60d08
peterharperuk
peterharperuk commented Feb 18, 2025
View reviewed changes
Copy link
Contributor Author

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I can't approve my own PR!

lurch
lurch reviewed Feb 18, 2025
View reviewed changes
pio/uart_pio_dma/uart_pio_dma.c
#define USE_DMA_FOR_TX 1

#define SERIAL_BAUD 921600
#define HARD_UART_INST uart1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity I just did some quick local compile-tests, and this code all still compiles if you replace

#define HARD_UART_INST uart1

with

#if !USE_PIO_FOR_RX || !USE_PIO_FOR_TX
#define HARD_UART_INST uart1
#endif

😉 (which perhaps makes it clearer that the "hard UART" isn't used at all when PIO is being used for both RX and TX?)

@kilograham kilograham merged commit b22ac95 into raspberrypi:develop Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@kilograham kilograham kilograham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@peterharperuk @lurch @kilograham