Automatic reloading of the helper pod manifest by the provisioner #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@js185692 Thanks for the contribution. Ping me if it is ready. Thank you. |
|
@derekbit the PR should be ready for review now, thanks! |
derekbit
approved these changes
May 26, 2024
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jun 5, 2024
…7 ) (#4774) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://togithub.com/rancher/local-path-provisioner) | patch | `v0.0.26` -> `v0.0.27` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.27`](https://togithub.com/rancher/local-path-provisioner/releases/tag/v0.0.27): Local Path Provisioner v0.0.27 [Compare Source](https://togithub.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27) #### What's Changed - Repair code example in storageClass description. by [@​c4lliope](https://togithub.com/c4lliope) in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - Update README.md to 0.26 by [@​e-minguez](https://togithub.com/e-minguez) in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - Update README.md,rm /manager by [@​terryzwt](https://togithub.com/terryzwt) in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - Fix duplicate labels by [@​runningman84](https://togithub.com/runningman84) in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - drone: remove s390x support by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/391](https://togithub.com/rancher/local-path-provisioner/pull/391) - Feature/multiple storage classes by [@​meln5674](https://togithub.com/meln5674) in [/~https://github.com/rancher/local-path-provisioner/pull/361](https://togithub.com/rancher/local-path-provisioner/pull/361) - Remove duplicate labels and add ability to set helperpod resource requests/limits by [@​visokoo](https://togithub.com/visokoo) in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - Automatic reloading of the helper pod manifest by the provisioner by [@​js185692](https://togithub.com/js185692) in [/~https://github.com/rancher/local-path-provisioner/pull/399](https://togithub.com/rancher/local-path-provisioner/pull/399) - Add support for custom path patterns by [@​AlbanBedel](https://togithub.com/AlbanBedel) in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - adding pvc with node name example by [@​sebastianohl](https://togithub.com/sebastianohl) in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - Add e2e test for custom path patterns by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/404](https://togithub.com/rancher/local-path-provisioner/pull/404) - Give the helper pod more range of MCS categories by [@​galal-hussein](https://togithub.com/galal-hussein) in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - Fix: Chart.yaml file is missing on helm install by [@​jamshidi799](https://togithub.com/jamshidi799) in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - drone: disable e2e test by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/405](https://togithub.com/rancher/local-path-provisioner/pull/405) - Allow customizing helper pod by [@​justusbunsi](https://togithub.com/justusbunsi) in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) - test: use reclaimPolicy Delete instead by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/406](https://togithub.com/rancher/local-path-provisioner/pull/406) - chart: fix pathPattern by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/409](https://togithub.com/rancher/local-path-provisioner/pull/409) #### New Contributors - [@​c4lliope](https://togithub.com/c4lliope) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - [@​e-minguez](https://togithub.com/e-minguez) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - [@​terryzwt](https://togithub.com/terryzwt) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - [@​runningman84](https://togithub.com/runningman84) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - [@​visokoo](https://togithub.com/visokoo) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - [@​AlbanBedel](https://togithub.com/AlbanBedel) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - [@​sebastianohl](https://togithub.com/sebastianohl) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - [@​galal-hussein](https://togithub.com/galal-hussein) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - [@​jamshidi799](https://togithub.com/jamshidi799) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - [@​justusbunsi](https://togithub.com/justusbunsi) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) **Full Changelog**: rancher/local-path-provisioner@v0.0.26...v0.0.27 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jun 5, 2024
…7 ) (#4773) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://togithub.com/rancher/local-path-provisioner) | patch | `v0.0.26` -> `v0.0.27` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.27`](https://togithub.com/rancher/local-path-provisioner/releases/tag/v0.0.27): Local Path Provisioner v0.0.27 [Compare Source](https://togithub.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27) #### What's Changed - Repair code example in storageClass description. by [@​c4lliope](https://togithub.com/c4lliope) in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - Update README.md to 0.26 by [@​e-minguez](https://togithub.com/e-minguez) in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - Update README.md,rm /manager by [@​terryzwt](https://togithub.com/terryzwt) in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - Fix duplicate labels by [@​runningman84](https://togithub.com/runningman84) in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - drone: remove s390x support by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/391](https://togithub.com/rancher/local-path-provisioner/pull/391) - Feature/multiple storage classes by [@​meln5674](https://togithub.com/meln5674) in [/~https://github.com/rancher/local-path-provisioner/pull/361](https://togithub.com/rancher/local-path-provisioner/pull/361) - Remove duplicate labels and add ability to set helperpod resource requests/limits by [@​visokoo](https://togithub.com/visokoo) in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - Automatic reloading of the helper pod manifest by the provisioner by [@​js185692](https://togithub.com/js185692) in [/~https://github.com/rancher/local-path-provisioner/pull/399](https://togithub.com/rancher/local-path-provisioner/pull/399) - Add support for custom path patterns by [@​AlbanBedel](https://togithub.com/AlbanBedel) in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - adding pvc with node name example by [@​sebastianohl](https://togithub.com/sebastianohl) in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - Add e2e test for custom path patterns by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/404](https://togithub.com/rancher/local-path-provisioner/pull/404) - Give the helper pod more range of MCS categories by [@​galal-hussein](https://togithub.com/galal-hussein) in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - Fix: Chart.yaml file is missing on helm install by [@​jamshidi799](https://togithub.com/jamshidi799) in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - drone: disable e2e test by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/405](https://togithub.com/rancher/local-path-provisioner/pull/405) - Allow customizing helper pod by [@​justusbunsi](https://togithub.com/justusbunsi) in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) - test: use reclaimPolicy Delete instead by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/406](https://togithub.com/rancher/local-path-provisioner/pull/406) - chart: fix pathPattern by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/409](https://togithub.com/rancher/local-path-provisioner/pull/409) #### New Contributors - [@​c4lliope](https://togithub.com/c4lliope) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - [@​e-minguez](https://togithub.com/e-minguez) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - [@​terryzwt](https://togithub.com/terryzwt) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - [@​runningman84](https://togithub.com/runningman84) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - [@​visokoo](https://togithub.com/visokoo) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - [@​AlbanBedel](https://togithub.com/AlbanBedel) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - [@​sebastianohl](https://togithub.com/sebastianohl) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - [@​galal-hussein](https://togithub.com/galal-hussein) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - [@​jamshidi799](https://togithub.com/jamshidi799) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - [@​justusbunsi](https://togithub.com/justusbunsi) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) **Full Changelog**: rancher/local-path-provisioner@v0.0.26...v0.0.27 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
sp3nx0r
referenced
this pull request
in sp3nx0r/homelab
Jun 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://togithub.com/rancher/local-path-provisioner) | patch | `v0.0.26` -> `v0.0.28` | --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.28`](https://togithub.com/rancher/local-path-provisioner/releases/tag/v0.0.28): Local Path Provisioner v0.0.28 [Compare Source](https://togithub.com/rancher/local-path-provisioner/compare/v0.0.27...v0.0.28-rc1) #### What's Changed - Migrate CI to github Actions by [@​mantissahz](https://togithub.com/mantissahz) in [/~https://github.com/rancher/local-path-provisioner/pull/403](https://togithub.com/rancher/local-path-provisioner/pull/403) - fix(ci): allow to read docker hub secret by [@​mantissahz](https://togithub.com/mantissahz) in [/~https://github.com/rancher/local-path-provisioner/pull/412](https://togithub.com/rancher/local-path-provisioner/pull/412) - Revert "Give the helper pod more range of MCS categories" by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/421](https://togithub.com/rancher/local-path-provisioner/pull/421) - Temporarily disable TestPodWithMultipleStorageClasses by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/423](https://togithub.com/rancher/local-path-provisioner/pull/423) - Move helperPod namespace into metadata by [@​justusbunsi](https://togithub.com/justusbunsi) in [/~https://github.com/rancher/local-path-provisioner/pull/425](https://togithub.com/rancher/local-path-provisioner/pull/425) #### New Contributors - [@​justusbunsi](https://togithub.com/justusbunsi) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) - [@​mantissahz](https://togithub.com/mantissahz) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/403](https://togithub.com/rancher/local-path-provisioner/pull/403) **Full Changelog**: rancher/local-path-provisioner@v0.0.27...v0.0.28 ### [`v0.0.27`](https://togithub.com/rancher/local-path-provisioner/releases/tag/v0.0.27): Local Path Provisioner v0.0.27 [Compare Source](https://togithub.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27) #### What's Changed - Repair code example in storageClass description. by [@​c4lliope](https://togithub.com/c4lliope) in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - Update README.md to 0.26 by [@​e-minguez](https://togithub.com/e-minguez) in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - Update README.md,rm /manager by [@​terryzwt](https://togithub.com/terryzwt) in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - Fix duplicate labels by [@​runningman84](https://togithub.com/runningman84) in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - drone: remove s390x support by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/391](https://togithub.com/rancher/local-path-provisioner/pull/391) - Feature/multiple storage classes by [@​meln5674](https://togithub.com/meln5674) in [/~https://github.com/rancher/local-path-provisioner/pull/361](https://togithub.com/rancher/local-path-provisioner/pull/361) - Remove duplicate labels and add ability to set helperpod resource requests/limits by [@​visokoo](https://togithub.com/visokoo) in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - Automatic reloading of the helper pod manifest by the provisioner by [@​js185692](https://togithub.com/js185692) in [/~https://github.com/rancher/local-path-provisioner/pull/399](https://togithub.com/rancher/local-path-provisioner/pull/399) - Add support for custom path patterns by [@​AlbanBedel](https://togithub.com/AlbanBedel) in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - adding pvc with node name example by [@​sebastianohl](https://togithub.com/sebastianohl) in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - Add e2e test for custom path patterns by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/404](https://togithub.com/rancher/local-path-provisioner/pull/404) - Give the helper pod more range of MCS categories by [@​galal-hussein](https://togithub.com/galal-hussein) in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - Fix: Chart.yaml file is missing on helm install by [@​jamshidi799](https://togithub.com/jamshidi799) in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - drone: disable e2e test by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/405](https://togithub.com/rancher/local-path-provisioner/pull/405) - Allow customizing helper pod by [@​justusbunsi](https://togithub.com/justusbunsi) in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) - test: use reclaimPolicy Delete instead by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/406](https://togithub.com/rancher/local-path-provisioner/pull/406) - chart: fix pathPattern by [@​derekbit](https://togithub.com/derekbit) in [/~https://github.com/rancher/local-path-provisioner/pull/409](https://togithub.com/rancher/local-path-provisioner/pull/409) #### New Contributors - [@​c4lliope](https://togithub.com/c4lliope) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/368](https://togithub.com/rancher/local-path-provisioner/pull/368) - [@​e-minguez](https://togithub.com/e-minguez) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/373](https://togithub.com/rancher/local-path-provisioner/pull/373) - [@​terryzwt](https://togithub.com/terryzwt) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/379](https://togithub.com/rancher/local-path-provisioner/pull/379) - [@​runningman84](https://togithub.com/runningman84) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/393](https://togithub.com/rancher/local-path-provisioner/pull/393) - [@​visokoo](https://togithub.com/visokoo) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/394](https://togithub.com/rancher/local-path-provisioner/pull/394) - [@​AlbanBedel](https://togithub.com/AlbanBedel) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/385](https://togithub.com/rancher/local-path-provisioner/pull/385) - [@​sebastianohl](https://togithub.com/sebastianohl) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/382](https://togithub.com/rancher/local-path-provisioner/pull/382) - [@​galal-hussein](https://togithub.com/galal-hussein) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/402](https://togithub.com/rancher/local-path-provisioner/pull/402) - [@​jamshidi799](https://togithub.com/jamshidi799) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/388](https://togithub.com/rancher/local-path-provisioner/pull/388) - [@​justusbunsi](https://togithub.com/justusbunsi) made their first contribution in [/~https://github.com/rancher/local-path-provisioner/pull/365](https://togithub.com/rancher/local-path-provisioner/pull/365) **Full Changelog**: rancher/local-path-provisioner@v0.0.26...v0.0.27 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In the readme, there is a section on reloading where it discusses the ability of the provisioner to be able to automatically pick up changes made to the config.
I have found that, while this works for changes made to the
setupandteardownscripts, when I make an update to the helper pod manifest in the config map the provisioner does not pick it up. I found that I would have to restart the provisioner for the helper pod changes to take effect.Changes
I have implemented a watch function of the helper pod manifest, that takes the file at the mount location (
/etc/config/) and sets the provisioner field ofhelperPodto that of the contents of the file.I have included a new env variable for the provisioner container that specifies the location of the config. This implementation is backwards compatible with deployments that don't have this env variable defined, as the resulting behaviour will be that of the current provisioner; meaning that changes made to the helper pod manifest in the config map will only take effect when the provisioner is restarted.
Note: I also updated in util to use
io.ReadAllinstead ofioutil.ReadAllas it was deprecated. I can change this back if it's necessary.