Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct directory naming for helm chart #231

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Correct directory naming for helm chart #231

merged 1 commit into from
Mar 22, 2022

Conversation

sidju
Copy link

@sidju sidju commented Feb 14, 2022

Tested fix for #230

@derekbit
Copy link
Member

@sidju
LGTM. Could you help resolve the conflict before merging it? Thank you.

@sidju
Copy link
Author

sidju commented Mar 22, 2022

I have just fixed the conflict.

derekbit
derekbit approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@derekbit derekbit merged commit 659e72d into rancher:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

@derekbit derekbit derekbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidju @derekbit @jenting