Replace attr.is:value queries with attr == "value". #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up as a result of discussions near the release of taskwarrior-2.4.1. It turns out that the 'attr.modifier:value' form of querying is deprecated. It won't go away for a long time, but we need to eventually move to 'attr == "value"'. This approach makes taskw perhaps more "helpful" than it should be in that the query that the user pretty explicitly specifies to python-taskw, gets changed under the covers before it is handed off to taskwarrior. This adds an extra test that failed before the code in ``taskw/utils.py`` was introduced. That new code change makes the test pass (and introduces no other new failures in the test suite). Tox is happy on a local run.
ralphbean
added a commit
that referenced
this pull request
Feb 17, 2015
Replace attr.is:value queries with attr == "value".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up as a result of discussions near the release of
taskwarrior-2.4.1. It turns out that the 'attr.modifier:value' form of
querying is deprecated. It won't go away for a long time, but we need
to eventually move to 'attr == "value"'.
This approach makes taskw perhaps more "helpful" than it should be in
that the query that the user pretty explicitly specifies to
python-taskw, gets changed under the covers before it is handed off to
taskwarrior.
This adds an extra test that failed before the code in
taskw/utils.pywas introduced. That new code change makes the testpass (and introduces no other new failures in the test suite). Tox is
happy on a local run.