Update to skip cleanup of built-in resources in Long Running Tests #8317

lakshmimsft · 2025-01-26T05:15:21Z

Description

Update to skip cleanup of built-in resources in Long Running Tests.
#8357

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

ytimocin

I believe we could use. better naming and we should add a note of why we need some resources to not be deleted.

.github/workflows/long-running-azure.yaml

ytimocin · 2025-01-26T05:22:34Z

.github/workflows/long-running-azure.yaml

+        if: env.SKIP_BUILD != 'true'
+        run: |
+          echo "Generating skip-resource-list..."
+          kubectl get resources.ucp.dev -n radius-system --no-headers -o custom-columns=":metadata.name" > skip-resource-list.txt


This is not only going to make us skip the manifest-related resources. I think it is going to make us skip the deletion of a lot of other Radius resources too, right?

skip-resources-list.txt is generated ONLY when new build is deployed. it will have the only necessary built-in resources we do not want to delete.

It is going to get all the resources of type resources.ucp.dev right? Would that include resources other than resource providers?

skip-delete-resource-list.txt
The entries for these resource-providers include entries for all resourcetypes and their associated entries including, apiversions supported, locations and their operation statuses. attaching an example from local build. All these entries are good to be preserved across runs before the next build/deploy where the cluster is cleaned out (all above entries deleted) and there is a fresh install and new skip-delete-resource-list.txt is re-generated.

.github/workflows/long-running-azure.yaml

radius-functional-tests · 2025-01-26T05:31:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`f41a2a5`
Unique ID	func013af0677e
Image tag	pr-func013af0677e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func013af0677e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func013af0677e
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func013af0677e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func013af0677e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func013af0677e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

codecov · 2025-01-26T05:35:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (e4db991) to head (c689e3c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8317   +/-   ##
=======================================
  Coverage   59.99%   60.00%           
=======================================
  Files         591      591           
  Lines       39554    39554           
=======================================
+ Hits        23731    23734    +3     
+ Misses      14058    14056    -2     
+ Partials     1765     1764    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-27T02:57:31Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`ad0abec`
Unique ID	func7cc663e069
Image tag	pr-func7cc663e069

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7cc663e069
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7cc663e069
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7cc663e069
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7cc663e069
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7cc663e069
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin

Let's test this out but kubectl get resources.ucp.dev -n radius-system --no-headers -o custom-columns=":metadata.name" > skip-delete-resources-list.txt will get all Radius resources to the don't delete list. Correct me if I am wrong.

radius-functional-tests · 2025-01-27T22:14:01Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`7d687e1`
Unique ID	func37cb44019b
Image tag	pr-func37cb44019b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func37cb44019b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func37cb44019b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func37cb44019b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func37cb44019b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func37cb44019b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>

radius-functional-tests · 2025-01-28T00:09:39Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`c689e3c`
Unique ID	funcbd1bd0baa8
Image tag	pr-funcbd1bd0baa8

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbd1bd0baa8
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbd1bd0baa8
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcbd1bd0baa8
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbd1bd0baa8
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbd1bd0baa8
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

lakshmimsft requested review from a team as code owners January 26, 2025 05:15

lakshmimsft temporarily deployed to publish-bicep January 26, 2025 05:15 — with GitHub Actions Inactive

lakshmimsft requested a review from ytimocin January 26, 2025 05:16

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from 2e8f499 to f41a2a5 Compare January 26, 2025 05:23

lakshmimsft temporarily deployed to publish-bicep January 26, 2025 05:24 — with GitHub Actions Inactive

ytimocin requested changes Jan 26, 2025

View reviewed changes

lakshmimsft temporarily deployed to functional-tests January 26, 2025 05:30 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from f41a2a5 to ad0abec Compare January 26, 2025 05:41

lakshmimsft temporarily deployed to publish-bicep January 26, 2025 05:41 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 27, 2025 02:56 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from ad0abec to b40c7f8 Compare January 27, 2025 08:03

lakshmimsft temporarily deployed to publish-bicep January 27, 2025 08:03 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from b40c7f8 to 7d687e1 Compare January 27, 2025 21:33

lakshmimsft temporarily deployed to publish-bicep January 27, 2025 21:34 — with GitHub Actions Inactive

ytimocin approved these changes Jan 27, 2025

View reviewed changes

lakshmimsft temporarily deployed to functional-tests January 27, 2025 22:13 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from 7d687e1 to 2e16a6b Compare January 27, 2025 22:23

lakshmimsft temporarily deployed to publish-bicep January 27, 2025 22:25 — with GitHub Actions Inactive

update to skip cleanup of built-in resources

c689e3c

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>

lakshmimsft force-pushed the lakshmimsft/setresourcestoignore-lrt branch from 2e16a6b to c689e3c Compare January 27, 2025 23:45

lakshmimsft temporarily deployed to publish-bicep January 27, 2025 23:45 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 28, 2025 00:08 — with GitHub Actions Inactive

lakshmimsft merged commit 9c0a579 into radius-project:main Jan 28, 2025
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to skip cleanup of built-in resources in Long Running Tests #8317

Update to skip cleanup of built-in resources in Long Running Tests #8317

lakshmimsft commented Jan 26, 2025 •

edited by vishwahiremat

Loading

ytimocin left a comment

ytimocin Jan 26, 2025

lakshmimsft Jan 26, 2025 •

edited

Loading

ytimocin Jan 27, 2025

lakshmimsft Jan 27, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 26, 2025 •

edited

Loading

codecov bot commented Jan 26, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 27, 2025 •

edited

Loading

ytimocin left a comment

radius-functional-tests bot commented Jan 27, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 28, 2025 •

edited

Loading

Update to skip cleanup of built-in resources in Long Running Tests #8317

Update to skip cleanup of built-in resources in Long Running Tests #8317

Conversation

lakshmimsft commented Jan 26, 2025 • edited by vishwahiremat Loading

Description

Type of change

Contributor checklist

ytimocin left a comment

Choose a reason for hiding this comment

ytimocin Jan 26, 2025

Choose a reason for hiding this comment

lakshmimsft Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

ytimocin Jan 27, 2025

Choose a reason for hiding this comment

lakshmimsft Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 26, 2025 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Jan 26, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Jan 27, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 27, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 28, 2025 • edited Loading

Radius functional test overview

Test Status

lakshmimsft commented Jan 26, 2025 •

edited by vishwahiremat

Loading

lakshmimsft Jan 26, 2025 •

edited

Loading

lakshmimsft Jan 27, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 26, 2025 •

edited

Loading

codecov bot commented Jan 26, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 27, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 27, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 28, 2025 •

edited

Loading