-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainers dependabot #8239
Conversation
Signed-off-by: sk593 <shruthikumar@microsoft.com>
9411e97
to
7e243ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8239 +/- ##
==========================================
+ Coverage 59.82% 59.84% +0.01%
==========================================
Files 590 590
Lines 39513 39513
==========================================
+ Hits 23639 23645 +6
+ Misses 14114 14110 -4
+ Partials 1760 1758 -2 ☔ View full report in Codecov by Sentry. |
What do you think about removing the |
We can remove it if there's no plan to add another one. If there is a tracking issue somewhere to add more dev containers, I think we should keep it but not otherwise. It's pretty low effort to add it back in if we ever change our minds |
Signed-off-by: sk593 <shruthikumar@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
The devcontainers dependabot update has been failing with the following error:
Error during file fetching; aborting: Neither .devcontainer.json nor .devcontainer/devcontainer.json nor .devcontainer/<anything>/devcontainer.json found in /.devcontainer/contributor
It's looking in the
.devcontainers/contributor
folder for different paths but the paths that it's looking for are only valid from the root directory. This PR updates the directory to the root so it can locate the devcontainer.json file correctly.Logs: /~https://github.com/radius-project/radius/actions/workflows/dependabot/dependabot-updates
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: