Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindcast and Projection Functions; Simply Results Paths #40

Merged
merged 5 commits into from
May 28, 2022

Conversation

lrennels
Copy link
Collaborator

@tonyewong this PR does two major things:

  1. Make run_hindcast and run_projections MimiBRICK functions
  2. Simply the use of results paths such that (1) we remove the date and chain length from the names of the files and (2) require users to input a output directory when running calibration. We don't really want things automatically going to a results folder for a package since users won't be able to a access results easily.

I recognize (2) might mess with some current scripts and your examples files which have those extensions, so I'm happy to talk this through but I think it's better for it as a package.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #40 (80dcf29) into master (6c10eb5) will increase coverage by 1.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   96.19%   97.22%   +1.02%     
==========================================
  Files          19       21       +2     
  Lines        1420     1766     +346     
==========================================
+ Hits         1366     1717     +351     
+ Misses         54       49       -5     
Flag Coverage Δ
unittests 97.22% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/calibration/calibration.jl 93.44% <100.00%> (+4.87%) ⬆️
src/calibration/calibration_helper_functions.jl 98.76% <100.00%> (+0.16%) ⬆️
src/calibration/run_hindcast.jl 100.00% <100.00%> (ø)
src/calibration/run_projections.jl 100.00% <100.00%> (ø)
src/downscale.jl 84.84% <100.00%> (-0.12%) ⬇️
src/components/glaciers_small_icecaps_component.jl 100.00% <0.00%> (+25.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lrennels lrennels merged commit 238258a into master May 28, 2022
@lrennels lrennels deleted the calibration-fcns branch May 28, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants