Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg #22

Merged
merged 9 commits into from
Apr 23, 2022
Merged

Pkg #22

merged 9 commits into from
Apr 23, 2022

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Apr 19, 2022

@tonyewong this PR addresses some of #20 and the main changes are:

  • Add continuous integration testing as well as move unit tests into the format needed to run CI checks
  • Move the whole MimiBRICK_DOECLIM.jl story from a module into just another creation function in create_models folder, like create_sneasy_brick.jl, and integrate this change into the rest of the code
  • Fix up some syntax customs
  • Update the README a bit
  • Start handling the examples (ask me before you use this, don't want to make you miserable with environments)

I think this can be merged once I fix the type error causing CI to fail and if it makes sense to you.

I think my next big steps are the following which I can put in another PR

  • the downscale.jl file is now included in the main MimiBRICK.jl package, but I think it might be a bit fragile in terms of file structure dependencies (or I don't fully understand them, regardless I don't see files like _MAP_..) -- either way let's discuss so we can decide how to include this in our examples and tests as desired
  • all the calibration work is in a separate folder, we should decide whether we want some of this to be within MimiBRICK and thus the functions imported with the package (I assume this is what we mostly want), or if it's more of an example -- if we want to move it I'd say we put a calibration folder into src and then create a master file that includes the various scripts, then we can include that in the MimiBRICK module

@lrennels
Copy link
Collaborator Author

Merging for now although a few tests fail on certain machine configurations

@lrennels lrennels merged commit f23ee4a into master Apr 23, 2022
@lrennels lrennels deleted the pkg branch April 23, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant