Adding BinaryPrimitives support for NETSTANDARD targets #851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds NETSTANDARD ifdefs for the binary serialization for more optimized code when targeting .NET Core applications. Thanks to @bollhals for the tip and the benchmarks showing greatly improved performance for those targets, which I had underestimated. See #801 for the discussion.
This does convolute the code a little bit (but not too much) and is mostly aimed at 6.X as these ifdefs can be removed for 7.0 later and we can just stick to the BinaryPrimitives method there.
Types of Changes
Checklist
CONTRIBUTING.md
document