Restore Constants class as public #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
May 13, 2020
michaelklishin
added a commit
that referenced
this pull request
May 13, 2020
Restore Constants class as public (cherry picked from commit 8f7a0b4)
bording
reviewed
May 13, 2020
| @@ -782,6 +782,36 @@ namespace RabbitMQ.Client.Exceptions | |||
| public object Offender { get; } | |||
| } | |||
| } | |||
| namespace RabbitMQ.Client.Framing | |||
There was a problem hiding this comment.
Instead of just bringing this back, could we change the namespace to RabbitMQ.Client instead?
There was a problem hiding this comment.
@lukebakken I like this idea. But this PR is already merged, so we'd need another one 🤷♂️
There was a problem hiding this comment.
Easy-peasy, I'll get it right now in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819