Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump regular System.Text.RegularExpressions due to a known CVE in earlier versions #1735

Merged

Conversation

aygalinc
Copy link
Contributor

Proposed Changes

Add explicit dependencies due to cve on System.Text.RegularExpressions

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

@michaelklishin michaelklishin changed the title chore: bump regular System.Text.RegularExpressions due to detected cve chore: bump regular System.Text.RegularExpressions due to known CVE in earlier versions Nov 28, 2024
@michaelklishin michaelklishin changed the title chore: bump regular System.Text.RegularExpressions due to known CVE in earlier versions chore: bump regular System.Text.RegularExpressions due to a known CVE in earlier versions Nov 28, 2024
@michaelklishin
Copy link
Member

@aygalinc it now complains about a CVE in System.Text.Json GHSA-8g4q-xg66-9fp4. Feel free to bump that library, too, since it is the same fundamental problem that now breaks builds on Windows.

@aygalinc
Copy link
Contributor Author

@michaelklishin Weird that the build fail by resolving a system text json lib in version 6 => if you have drop net6 in favor of net8 what can cause this ?
I work on macos so i cannot reproduce on my local env

@michaelklishin
Copy link
Member

@aygalinc I am not sure what in the Windows environment might have caused this. Possibly dependency lock file caching of sorts? We'll have to wait until @lukebakken comes back next week.

@lukebakken lukebakken added this to the 7.0.1 milestone Dec 1, 2024
@lukebakken lukebakken self-assigned this Dec 1, 2024
@Tornhoof
Copy link
Contributor

Tornhoof commented Dec 3, 2024

The package should only be relevant for .NET 4.7.2 targets, not the new one (similar to S.T.J).
See https://devblogs.microsoft.com/nuget/nugetaudit-2-0-elevating-security-and-trust-in-package-management/#system.net.http-and-system.text.regularexpressions

@lukebakken
Copy link
Contributor

@michaelklishin 53d484f bumps the version we use to identify cached NuGet deps and thus invalidates the cache. I bet that's the issue. I'll know soon!

* Increment the nuget cache version to invalidate the cache
* Add `Directory.Packages.props` to GHA NuGet cache
@lukebakken lukebakken force-pushed the fix/fix_cve_in_regular_expression_package branch from 3b2e933 to f373667 Compare December 6, 2024 18:40
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are not related to these changes. Thanks!

@lukebakken lukebakken merged commit e4e05a0 into rabbitmq:main Dec 6, 2024
10 of 11 checks passed
@lukebakken lukebakken modified the milestones: 7.0.1, 7.1.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants