-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump regular System.Text.RegularExpressions due to a known CVE in earlier versions #1735
chore: bump regular System.Text.RegularExpressions due to a known CVE in earlier versions #1735
Conversation
@aygalinc it now complains about a CVE in |
@michaelklishin Weird that the build fail by resolving a system text json lib in version 6 => if you have drop net6 in favor of net8 what can cause this ? |
@aygalinc I am not sure what in the Windows environment might have caused this. Possibly dependency lock file caching of sorts? We'll have to wait until @lukebakken comes back next week. |
The package should only be relevant for .NET 4.7.2 targets, not the new one (similar to S.T.J). |
@michaelklishin 53d484f bumps the version we use to identify cached NuGet deps and thus invalidates the cache. I bet that's the issue. I'll know soon! |
* Increment the nuget cache version to invalidate the cache * Add `Directory.Packages.props` to GHA NuGet cache
3b2e933
to
f373667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are not related to these changes. Thanks!
Proposed Changes
Add explicit dependencies due to cve on System.Text.RegularExpressions
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply