Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session events async #1679

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

danielmarbach
Copy link
Collaborator

Proposed Changes

Follow through on discussion in #1675 (comment)

@lukebakken mentioned his original intent was to make the events async across the board but stopped.

This PR would align the session API surface

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@danielmarbach danielmarbach mentioned this pull request Sep 18, 2024
11 tasks
@danielmarbach danielmarbach changed the title Async session events Make session events async Sep 18, 2024
@danielmarbach danielmarbach mentioned this pull request Sep 18, 2024
11 tasks
@danielmarbach
Copy link
Collaborator Author

The next PR after this one is merged is lined up #1680

@lukebakken lukebakken self-requested a review September 18, 2024 17:15
@lukebakken lukebakken added this to the 7.0.0 milestone Sep 18, 2024
@lukebakken lukebakken self-assigned this Sep 18, 2024
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danielmarbach

@lukebakken lukebakken merged commit 6f15686 into rabbitmq:main Sep 18, 2024
11 checks passed
@danielmarbach danielmarbach deleted the async-session-events branch September 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants